Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default ports value #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Dec 12, 2024

If an Ingress/Egress Ports field does not specify a Port value, but it has a valid Protocol, then the rule should match every possible port number.

Add unit and end2end test to cover the feature

If an Ingress/Egress Ports field does not specify a `Port` value, but it has a valid `Protocol`, then the rule should match
every possible port number.

Add unit and end2end test to cover the feature

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12312555896

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 58.16%

Totals Coverage Status
Change from base Build 10792446610: -0.5%
Covered Lines: 1119
Relevant Lines: 1924

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants